YARN-11909. Fix for fetching logs for a running application by p-szucs · Pull Request #8136 · apache/hadoop

p-szucs · 2025-12-15T16:35:43Z

Change-Id: I6af1b8805e6b056fb226aea99e01ab21c5bfd179

Description of PR

URL connectivity check in YARN Logs CLI can not connect to the RM on a secured environment when getting the logs for a running application.

Jersey 2 upgrade introduced a new logic for checking URL connectivity before getting the logs from the appropriate services.

This logic uses HttpURLConnection that can not load SSL configuration from the ssl-client.xml on a secure environment. As I can see in such cases we need to use HttpsURLConnection

How was this patch tested?

Tested on a secured and unsecured environment:

logs for a running application can be fetched on both
when I stopped the NMs, retry logic keeps trying the connections

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

Change-Id: I6af1b8805e6b056fb226aea99e01ab21c5bfd179

Change-Id: I3ff2da3568bf8aae174fa0df64a7a2996fcd439d

hadoop-yetus · 2025-12-15T19:45:07Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	2m 50s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	9m 55s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 28s		trunk passed
+1 💚	compile	7m 9s		trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 46s		trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	checkstyle	1m 34s		trunk passed
+1 💚	mvnsite	2m 1s		trunk passed
+1 💚	javadoc	2m 4s		trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 58s		trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	spotbugs	3m 23s		trunk passed
+1 💚	shadedclient	27m 18s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 4s		the patch passed
+1 💚	compile	6m 14s		the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 14s		the patch passed
+1 💚	compile	6m 55s		the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 33s		the patch passed
+1 💚	mvnsite	1m 50s		the patch passed
-1 ❌	javadoc	1m 5s	/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt	hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 generated 1 new + 2713 unchanged - 0 fixed = 2714 total (was 2713)
-1 ❌	javadoc	1m 2s	/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt	hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 generated 1 new + 2439 unchanged - 0 fixed = 2440 total (was 2439)
+1 💚	spotbugs	3m 34s		the patch passed
+1 💚	shadedclient	28m 33s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 47s		hadoop-yarn-common in the patch passed.
+1 💚	unit	28m 17s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	1m 9s		The patch does not generate ASF License warnings.
		187m 44s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8136/1/artifact/out/Dockerfile
GITHUB PR	#8136
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 38a5834aa7f3 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `75e1b2b`
Default Java	Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8136/1/testReport/
Max. process+thread count	633 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8136/1/console
versions	git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2025-12-15T20:31:09Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	1m 34s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	10m 3s		Maven dependency ordering for branch
+1 💚	mvninstall	30m 2s		trunk passed
+1 💚	compile	7m 14s		trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	compile	6m 58s		trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	checkstyle	1m 35s		trunk passed
+1 💚	mvnsite	1m 59s		trunk passed
+1 💚	javadoc	2m 0s		trunk passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	javadoc	1m 54s		trunk passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	spotbugs	3m 32s		trunk passed
+1 💚	shadedclient	28m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 28s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 6s		the patch passed
+1 💚	compile	6m 17s		the patch passed with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 17s		the patch passed
+1 💚	compile	6m 55s		the patch passed with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
+1 💚	javac	6m 55s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 34s		the patch passed
+1 💚	mvnsite	1m 47s		the patch passed
-1 ❌	javadoc	1m 8s	/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04.txt	hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-21.0.7+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 generated 1 new + 2713 unchanged - 0 fixed = 2714 total (was 2713)
-1 ❌	javadoc	1m 5s	/results-javadoc-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04.txt	hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-jdkUbuntu-17.0.15+6-Ubuntu-0ubuntu120.04 with JDK Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04 generated 1 new + 2439 unchanged - 0 fixed = 2440 total (was 2439)
+1 💚	spotbugs	3m 40s		the patch passed
+1 💚	shadedclient	27m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	5m 47s		hadoop-yarn-common in the patch passed.
+1 💚	unit	28m 20s		hadoop-yarn-client in the patch passed.
+1 💚	asflicense	1m 11s		The patch does not generate ASF License warnings.
		189m 40s

Subsystem	Report/Notes
Docker	ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8136/2/artifact/out/Dockerfile
GITHUB PR	#8136
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux f49e1c548bf6 5.15.0-156-generic #166-Ubuntu SMP Sat Aug 9 00:02:46 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `f2a7bdc`
Default Java	Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Multi-JDK versions	/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.7+6-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.15+6-Ubuntu-0ubuntu120.04
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8136/2/testReport/
Max. process+thread count	638 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8136/2/console
versions	git=2.25.1 maven=3.9.11 spotbugs=4.9.7
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2025-12-16T23:58:24Z


-  @VisibleForTesting
-  SSLFactory getSSLFactory() {
+  public static SSLFactory getSSLFactory() {


Why do we need to modify this part?

Thanks for the review @slfan1989!
As I could see we can not reach the SSL factory from the Logs CLI without this

p-szucs · 2026-02-04T14:05:05Z

Hi @slfan1989,
May I ask another round of review if you will have the time for that, please?

YARN-11909. Fix for fetching logs for a running application

75e1b2b

Change-Id: I6af1b8805e6b056fb226aea99e01ab21c5bfd179

github-actions Bot added YARN trunk labels Dec 15, 2025

YARN-11909. Destroy SSL factory after the run command

f2a7bdc

Change-Id: I3ff2da3568bf8aae174fa0df64a7a2996fcd439d

slfan1989 reviewed Dec 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11909. Fix for fetching logs for a running application#8136

YARN-11909. Fix for fetching logs for a running application#8136
p-szucs wants to merge 2 commits intoapache:trunkfrom
p-szucs:YARN-11909-logs-cli-fix

p-szucs commented Dec 15, 2025

Uh oh!

hadoop-yetus commented Dec 15, 2025

Uh oh!

hadoop-yetus commented Dec 15, 2025

Uh oh!

slfan1989 Dec 16, 2025

Uh oh!

p-szucs Dec 18, 2025

Uh oh!

p-szucs commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

p-szucs commented Dec 15, 2025

Description of PR

How was this patch tested?

For code changes:

Uh oh!

hadoop-yetus commented Dec 15, 2025

Uh oh!

hadoop-yetus commented Dec 15, 2025

Uh oh!

slfan1989 Dec 16, 2025

Choose a reason for hiding this comment

Uh oh!

p-szucs Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

p-szucs commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants