-
Notifications
You must be signed in to change notification settings - Fork 985
Rfc6724 resolver ordering semantics #778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arturobernalg
wants to merge
2
commits into
apache:master
Choose a base branch
from
arturobernalg:Rfc6724A
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,281
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
87 changes: 87 additions & 0 deletions
87
httpclient5-testing/src/test/java/org/apache/hc/client5/testing/ManualRfc6724ResolverIT.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| /* | ||
| * ==================================================================== | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| * ==================================================================== | ||
| * | ||
| * This software consists of voluntary contributions made by many | ||
| * individuals on behalf of the Apache Software Foundation. For more | ||
| * information on the Apache Software Foundation, please see | ||
| * <http://www.apache.org/>. | ||
| * | ||
| */ | ||
|
|
||
| package org.apache.hc.client5.testing; | ||
|
|
||
| import static org.junit.jupiter.api.Assumptions.assumeTrue; | ||
|
|
||
| import java.net.Inet6Address; | ||
| import java.net.InetAddress; | ||
|
|
||
| import org.apache.hc.client5.http.DnsResolver; | ||
| import org.apache.hc.client5.http.Rfc6724AddressSelectingDnsResolver; | ||
| import org.apache.hc.client5.http.SystemDefaultDnsResolver; | ||
| import org.apache.hc.client5.http.config.ProtocolFamilyPreference; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| class ManualRfc6724ResolverIT { | ||
|
|
||
| private static final String PROP_ENABLE = "httpclient.rfc6724.it"; | ||
| private static final String PROP_HOST = "httpclient.rfc6724.host"; | ||
|
|
||
| @Test | ||
| void resolve_and_dump_order() throws Exception { | ||
| assumeTrue(Boolean.getBoolean(PROP_ENABLE), | ||
| "Enable with -Dhttpclient.rfc6724.it=true"); | ||
|
Comment on lines
+48
to
+49
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd rather control this with JUnit 5 tags somehow. The advantage of what you've done here is that we don't have to define an entire Maven profile for this test, but we could add support in our build for controlling test selection via system properties. |
||
|
|
||
| final String host = System.getProperty(PROP_HOST, "localhost"); | ||
|
|
||
| final DnsResolver base = SystemDefaultDnsResolver.INSTANCE; | ||
|
|
||
| System.out.println("Host: " + host); | ||
|
|
||
| dump(base, host, ProtocolFamilyPreference.DEFAULT); | ||
| System.out.println(); | ||
| dump(base, host, ProtocolFamilyPreference.INTERLEAVE); | ||
| } | ||
|
|
||
| private static void dump( | ||
| final DnsResolver base, | ||
| final String host, | ||
| final ProtocolFamilyPreference pref) throws Exception { | ||
|
|
||
| final Rfc6724AddressSelectingDnsResolver resolver = | ||
| new Rfc6724AddressSelectingDnsResolver(base, pref); | ||
|
|
||
| final InetAddress[] out = resolver.resolve(host); | ||
|
|
||
| int v4 = 0; | ||
| int v6 = 0; | ||
|
|
||
| System.out.println("Preference: " + pref); | ||
| for (final InetAddress a : out) { | ||
| if (a instanceof Inet6Address) { | ||
| v6++; | ||
| System.out.println(" IPv6 " + a.getHostAddress()); | ||
| } else { | ||
| v4++; | ||
| System.out.println(" IPv4 " + a.getHostAddress()); | ||
| } | ||
| } | ||
| System.out.println("Counts: IPv4=" + v4 + " IPv6=" + v6); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.