add X-Client-Version header to rest client #2910
Merged
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
reviewed
Jan 14, 2026
kevinjqliu
approved these changes
Jan 14, 2026
Contributor
kevinjqliu
left a comment
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM
this follows the java implementation to pin a client version
https://github.com/apache/iceberg/blob/b62802faf9edc2aca89a85a1ab0a6e13e1b61472/api/src/main/java/org/apache/iceberg/IcebergBuild.java#L67
kevinjqliu
changed the title
Contributor
|
Thanks @nssalian |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2373
Rationale for this change
Bringing parity to the headers in Python.
The version is as per the HttpClient in Java and the version string is matching IcebergBuild but with
PyIceberginstead of Iceberg.Previously, this was worked on #2652 but since that has stalled, adding a fix to close our the issue. Thanks to @jaimeferj for his original PR.
Are these changes tested?
tests/catalog/test_rest.py-test_client_version_headerAre there any user-facing changes?
No