Merged
Conversation
kevinjqliu
approved these changes
Jan 20, 2026
Contributor
|
tested out the same scenario manually. |
Contributor
|
i also noticed that |
kevinjqliu
approved these changes
Jan 20, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
In #2928, the
uv.lockwasn't generated correctly after a dependency change.Adding the following changes:
make uv-lockto generate one when modifying dependenciesmake uv-lock-checkto check if theuv.lockis up to dateuv.lockand fail if not updated correctly (uses 2.)mkdocs/docs/contributing.mdto add instructions for contributors.Are these changes tested?
Locally.
Added some of the dependencies in #2928 without modifying the lock file and ran
pre-commit run --all-filesto observe the following failure messageAre there any user-facing changes?
No. Useful for contributions that change versions/ dependencies.