Fix bytes_required over-allocation for negative powers of two#3548
Open
ArjunPakhan wants to merge 1 commit into
Open
Fix bytes_required over-allocation for negative powers of two#3548ArjunPakhan wants to merge 1 commit into
ArjunPakhan wants to merge 1 commit into
Conversation
ebyhr
reviewed
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue in
bytes_requiredwhere negative numbers that are exact powers of two (e.g.,-128,-32768) were over-allocated an extra byte of space.Context & Root Cause
In two's complement representation, exact negative powers of two are clean boundaries where the Most Significant Bit (MSB) naturally represents the sign without requiring an extra padding bit. For example,
-128fits perfectly within a single signed byte (0x80).The previous implementation calculated the byte length using Python's native
.bit_length()directly on the integer magnitude: