Fix TruncateTransform.satisfies_order_of crashing on different widths#3682
Open
SAY-5 wants to merge 1 commit into
Open
Fix TruncateTransform.satisfies_order_of crashing on different widths#3682SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
Signed-off-by: Sai Asish Y <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3680
Rationale for this change
TruncateTransform.satisfies_order_ofreadsself.source_type(andother.source_type) when the two transforms are not equal, butTruncateTransform.__init__only sets_widthand never sets_source_type. Comparing two truncate transforms of different widths therefore raisesAttributeError: 'TruncateTransform' object has no attribute '_source_type'instead of returning a boolean, because same-width comparisons only work by taking the earlyself == otherreturn. Two truncate transforms are ordered by width, so the comparison can be decided from the widths alone.Are these changes tested?
Yes. Added
test_truncate_satisfies_order_of_different_widthsand confirmed the existing transform tests still pass (pytest tests/test_transforms.py -k "truncate or satisfies_order"). The twotest_truncate_pyarrow_transformscases that fail locally require the optionalpyiceberg-coreextra and are unrelated to this change.Are there any user-facing changes?
No.