feat(iceberg): Enable delete files processing in snapshot producer#2367
Open
CTTY wants to merge 4 commits intoapache:mainfrom
Open
feat(iceberg): Enable delete files processing in snapshot producer#2367CTTY wants to merge 4 commits intoapache:mainfrom
CTTY wants to merge 4 commits intoapache:mainfrom
Conversation
CTTY
commented
Apr 24, 2026
1 task
xanderbailey
reviewed
May 7, 2026
Contributor
xanderbailey
left a comment
xanderbailey
left a comment
There was a problem hiding this comment.
Nice PR! Took a pass at reviewing, let me know if it makes sense!
Comment on lines
-87
to
94
| let snapshot_producer = SnapshotProducer::new( | ||
| table, | ||
| self.commit_uuid.unwrap_or_else(Uuid::now_v7), | ||
| self.key_metadata.clone(), | ||
| self.snapshot_properties.clone(), | ||
| self.added_data_files.clone(), | ||
| ); | ||
| let snapshot_producer = SnapshotProducer::builder() | ||
| .with_table(table) | ||
| .with_commit_uuid(self.commit_uuid.unwrap_or_else(Uuid::now_v7)) | ||
| .with_key_metadata(self.key_metadata.clone()) | ||
| .with_snapshot_properties(self.snapshot_properties.clone()) | ||
| .with_added_data_files(self.added_data_files.clone()) | ||
| .build(); | ||
|
|
| .default_partition_spec() | ||
| .as_ref() | ||
| .partition_spec_by_id(spec_id) | ||
| .ok_or(Error::new( |
Contributor
There was a problem hiding this comment.
ok_or will allocate the error on the success path, ok_or_else might be better?
| /// Reference to [`Snapshot`]. | ||
| pub type SnapshotRef = Arc<Snapshot>; | ||
| #[derive(Debug, Default, Serialize, Deserialize, PartialEq, Eq, Clone)] | ||
| #[derive(Debug, Default, Serialize, Deserialize, PartialEq, Eq, Clone, Hash)] |
Contributor
There was a problem hiding this comment.
Why does this need to be Hash now?
|
|
||
| summary_collector.set_partition_summary_limit(partition_summary_limit); | ||
|
|
||
| for data_file in &self.added_data_files { |
Contributor
There was a problem hiding this comment.
Do we need to include these changes in the summary here?
| if added_files.is_empty() { | ||
| return Err(Error::new( | ||
| ErrorKind::PreconditionFailed, | ||
| "No added data files found when write an added manifest file", |
Contributor
There was a problem hiding this comment.
Does this need to be updated to added data / delete files?
| async fn existing_manifest( | ||
| &self, | ||
| snapshot_produce: &SnapshotProducer<'_>, | ||
| snapshot_produce: &mut SnapshotProducer<'_>, |
Contributor
There was a problem hiding this comment.
Does this need to be mut?
Comment on lines
+342
to
+344
| if deleted_entries.is_empty() { | ||
| Ok(Vec::new()) | ||
| } else { |
Contributor
There was a problem hiding this comment.
nit: can we early return here to avoid the nesting?
Suggested change
| if deleted_entries.is_empty() { | |
| Ok(Vec::new()) | |
| } else { | |
| if deleted_entries.is_empty() { | |
| return Ok(Vec::new()) | |
| } |
| } | ||
| } | ||
|
|
||
| pub(crate) fn validate_added_data_files(&self) -> Result<()> { |
Contributor
There was a problem hiding this comment.
Java has a validateDeleteFileForVersion which might be nice to have the same? https://github.com/apache/iceberg/blob/0f657edf12dc29f8487a679bfdd4210e9588d014/core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java#L295-L316
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
Added uts in snapshot.rs, we should add end-to-end tests when actual rewrite/delete actions are supported