fix(sqllogictest): add missing tokio rt-multi-thread feature#2386
Merged
CTTY merged 1 commit intoapache:mainfrom May 4, 2026
Merged
Conversation
blackmwk
reviewed
Apr 30, 2026
| serde = { workspace = true } | ||
| tracing = { workspace = true } | ||
| tokio = { workspace = true } | ||
| tokio = { workspace = true, features = ["rt-multi-thread"] } |
Contributor
There was a problem hiding this comment.
Should we also use full features?
Contributor
Author
There was a problem hiding this comment.
rt-multi-thread is the only feature required here (Builder::new_multi_thread()).
Using full would also fix the bug.
Contributor
might be worth fixing this in case there are other similar issues |
Contributor
|
opened #2389, CI should fail in that CI because the tokio fix isnt included |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
cargo test -p iceberg-sqllogictestfails to compile: missing tokiort-multi-threadfeature #2385 .What changes are included in this PR?
crates/sqllogictest/Cargo.tomlwas missing thert-multi-threadfeature for tokio, whiletests/sqllogictests.rscallstokio::runtime::Builder::new_multi_thread()which requires it.This meant
cargo test -p iceberg-sqllogictestfailed to compile when run in isolation. The issue was invisible when usingmake build(--all-features --workspace) becausecrates/examplesalready enablestokio = { features = ["full"] }, and Cargo features are additive across the workspace graph.Are these changes tested?
cargo test -p iceberg-sqllogictest