Core: Make Metadata Timestamp Clock Skew Configurable#17286
Open
chandrasekhar-188k wants to merge 1 commit into
Open
Core: Make Metadata Timestamp Clock Skew Configurable#17286chandrasekhar-188k wants to merge 1 commit into
chandrasekhar-188k wants to merge 1 commit into
Conversation
singhpk234
reviewed
Jul 18, 2026
Comment on lines
+74
to
+77
| static final String CLOCK_SKEW_TOLERANCE_MS_PROPERTY = | ||
| "iceberg.table-metadata.clock-skew-tolerance-ms"; | ||
|
|
||
| private static final long DEFAULT_CLOCK_SKEW_TOLERANCE_MS = ONE_MINUTE; |
Contributor
There was a problem hiding this comment.
whats the motivation for doing this ?
heads up in v4 we need to have monotonic timestamps
cc @stevenzwu
Author
There was a problem hiding this comment.
in deployments where multiple compute engines (for example, Spark, Flink, Trino, or custom applications) operate on the same Iceberg table from different clusters, temporary clock skew greater than one minute can occur despite otherwise healthy deployments. In such cases, valid commits may fail because the metadata timestamp appears to be too far in the future relative to the committing process. we have observed this issue in some of our deployments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make Metadata Timestamp Clock Skew Configurable
fixes: #17285