IGNITE-27994 Create CLI command for REST endpoint to edit cluster name#7740
Open
adityamukho wants to merge 8 commits intoapache:mainfrom
Open
IGNITE-27994 Create CLI command for REST endpoint to edit cluster name#7740adityamukho wants to merge 8 commits intoapache:mainfrom
adityamukho wants to merge 8 commits intoapache:mainfrom
Conversation
Phillippko
reviewed
Mar 11, 2026
| /** | ||
| * Tests for {@link ClusterRenameCall}. | ||
| */ | ||
| public class ItRenameCallTest extends CliIntegrationTest { |
Contributor
There was a problem hiding this comment.
Suggested change
| public class ItRenameCallTest extends CliIntegrationTest { | |
| public class ItClusterRenameCallTest extends CliIntegrationTest { |
| } | ||
| } | ||
|
|
||
| private DefaultCallOutput<String> updateClusterConfig(ClusterManagementApi api, ClusterRenameCallInput input) |
Contributor
There was a problem hiding this comment.
I would inline these methods
|
|
||
| try { | ||
| return updateClusterConfig(client, input); | ||
| } catch (ApiException | IllegalArgumentException e) { |
Contributor
There was a problem hiding this comment.
Suggested change
| } catch (ApiException | IllegalArgumentException e) { | |
| } catch (ApiException) { |
don't see where would illegal argument come from
| import picocli.CommandLine.Parameters; | ||
|
|
||
| /** | ||
| * Mixin class for cluster name option in REPL mode. |
Contributor
There was a problem hiding this comment.
Suggested change
| * Mixin class for cluster name option in REPL mode. | |
| * Mixin class for cluster name. |
| ) | ||
| private String name; | ||
|
|
||
| private String nameFromArgs() { |
Contributor
There was a problem hiding this comment.
I wonder if we really need to provide both options (--name / just as an arg)
| /** | ||
| * Tests for {@link ClusterRenameCall}. | ||
| */ | ||
| public class ItRenameCallTest extends CliIntegrationTest { |
Contributor
There was a problem hiding this comment.
Discussed with Vadim Pakhnushev, there is no point in separate tests for calls. Please replace with a test for command
ALso we need tests for different cases. Quoted, unquoted, empty name, etc
|
|
||
| /** Name that will be updated. */ | ||
| @Mixin | ||
| private ClusterNameMixin nameFromArgs; |
Contributor
There was a problem hiding this comment.
Suggested change
| private ClusterNameMixin nameFromArgs; | |
| private ClusterNameMixin name; |
| import org.junit.jupiter.params.provider.Arguments; | ||
| import org.junit.jupiter.params.provider.MethodSource; | ||
|
|
||
| class RenameTest extends CliCommandTestBase { |
Contributor
There was a problem hiding this comment.
Suggested change
| class RenameTest extends CliCommandTestBase { | |
| class ClusterRenameCommandTest extends CliCommandTestBase { |
|
|
||
| private static Stream<Arguments> calls() { | ||
| return Stream.of( | ||
| arguments( |
| Class<IT> callInputClass, | ||
| Function<IT, String> nameFunction | ||
| ) { | ||
| checkParameters(command, callClass, callInputClass, nameFunction, "test1 test2", "test1 test2"); |
Contributor
There was a problem hiding this comment.
let's use parameterizedtest to unite these tests, passing args / expected name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27994