IGNITE-27521 Java client: handle multiple endpoints for the same node#7745
Open
ptupitsyn wants to merge 12 commits intoapache:mainfrom
Open
IGNITE-27521 Java client: handle multiple endpoints for the same node#7745ptupitsyn wants to merge 12 commits intoapache:mainfrom
ptupitsyn wants to merge 12 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses IGNITE-27521 by improving the Java thin client behavior when multiple distinct endpoints resolve to the same server node, adding a warning and extending test coverage for the scenario.
Changes:
- Add a warning log when different endpoints connect to the same server node.
- Update
connections()reporting to reflect multiple active endpoint connections to the same node (while skipping duplicate-config weights). - Add a new DNS discovery test that asserts the warning is logged and that both connections are tracked and closed.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| modules/client/src/test/java/org/apache/ignite/client/ClientDnsDiscoveryTest.java | Adds a new test for “multiple endpoints -> same node” and wires a test logger into client configuration. |
| modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java | Emits a warning on multi-endpoint-to-same-node detection and adjusts connections() to enumerate per-endpoint holders. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/client/src/test/java/org/apache/ignite/client/ClientDnsDiscoveryTest.java
Outdated
Show resolved
Hide resolved
modules/client/src/test/java/org/apache/ignite/client/ClientDnsDiscoveryTest.java
Show resolved
Hide resolved
modules/client/src/test/java/org/apache/ignite/client/ClientDnsDiscoveryTest.java
Show resolved
Hide resolved
modules/client/src/main/java/org/apache/ignite/internal/client/ReliableChannel.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/IGNITE-27521