Skip to content

[MINOR] Compile time check for Message default constructor added #13220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nizhikov wants to merge 2 commits into
base: master
Choose a base branch
from
+33 −0
Open

[MINOR] Compile time check for Message default constructor added #13220

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40bbbb4
Compile time check for Message default constructor added
nizhikov Jun 8, 2026
9555ab7
Update modules/codegen/src/main/java/org/apache/ignite/internal/Messa…
nizhikov Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions modules/codegen/src/main/java/org/apache/ignite/internal/MessageProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,14 @@
import javax.lang.model.SourceVersion;
import javax.lang.model.element.Element;
import javax.lang.model.element.ElementKind;
import javax.lang.model.element.ExecutableElement;
import javax.lang.model.element.Modifier;
import javax.lang.model.element.TypeElement;
import javax.lang.model.element.VariableElement;
import javax.lang.model.type.TypeKind;
import javax.lang.model.type.TypeMirror;
import javax.tools.Diagnostic;
import org.apache.ignite.internal.util.typedef.F;
import org.apache.ignite.lang.IgniteBiTuple;

import static org.apache.ignite.internal.MessageSerializerGenerator.DLFT_ENUM_MAPPER_CLS;
Expand Down Expand Up @@ -115,6 +117,9 @@ public class MessageProcessor extends AbstractProcessor {
if (clazz.getModifiers().contains(Modifier.ABSTRACT))
continue;

if (!checkConstructors(clazz))
continue;

List<VariableElement> fields = orderedFields(clazz);

if (fields.isEmpty() && emptyMsgs.stream().noneMatch(t -> isAssignable(t, clazz))) {
Expand Down Expand Up @@ -146,6 +151,34 @@ public class MessageProcessor extends AbstractProcessor {
return true;
}

/** */
private boolean checkConstructors(TypeElement clazz) {
boolean isMarshallableMsg = isAssignable(
clazz.asType(),
processingEnv.getElementUtils().getTypeElement("org.apache.ignite.internal.MarshallableMessage")
);

for (Element el : clazz.getEnclosedElements()) {
if (el.getKind() != ElementKind.CONSTRUCTOR)
continue;

ExecutableElement c = (ExecutableElement)el;

boolean isDfltConstructor = F.isEmpty(c.getParameters());

if (isDfltConstructor && !isMarshallableMsg)

@shishkovilja shishkovilja Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need check that message is marshallable, because MarshallableMessage inheritors should have default constructor too:

ignite/modules/core/src/main/java/org/apache/ignite/internal/plugin/AbstractMarshallableMessageFactoryProvider.java

Line 68 in 938452e

ctor = cls.getConstructor();

Also we need to check that constructor is pulbic, eg.:

c.getModifiers().contains(Modifier.PUBLIC);

return true;
}

processingEnv.getMessager().printMessage(
Diagnostic.Kind.ERROR,
"A class must have a default constructor: " + clazz.getQualifiedName(),

@shishkovilja shishkovilja Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"A class must have a default constructor: " + clazz.getQualifiedName(),
"A class must have a public default constructor: " + clazz.getQualifiedName(),

clazz
);

return false;
}

/**
* Collects all fields annotated with {@link Order} from the given {@link TypeElement} and all its superclasses.
* <p>
Expand Down
Loading