[BUILD] Use Lifecycle.PER_CLASS in integration tests #2993
[BUILD] Use Lifecycle.PER_CLASS in integration tests #2993chibenwa wants to merge 6 commits intoapache:masterfrom
Conversation
|
03:48:13.206 [ERROR] o.a.j.GuiceJamesServer - Fatal error while starting James => https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-2993/3/testReport/ |
| void cleanUp(GuiceJamesServer server) { | ||
| server.getProbe(CleanupTasksPerformerProbe.class).clean(); |
There was a problem hiding this comment.
Should we have an OpenSearch cleanup step to clean up the documents (POST /<index-or-alias>/_delete_by_query with match_all ?) ?
Not sure if the current isolation is good for the email query test suite (it seems failed on my local).
There was a problem hiding this comment.
Thought about it, but it's actually not needed.
Opensearch is mailboxId scoped with access rights piloted against the Cassandra DB.
There is no need to clean as the ids of the second test will differ from the first.
There was a problem hiding this comment.
As said, your comment makes sense. However, on CI, we are doing smoke testing. We still need to make sure local passes (seems not the case with Email query contract at least)
There was a problem hiding this comment.
I'd do this on the CI...
chibenwa
force-pushed
the
faster-it-2
branch
2 times, most recently
from
bae0944 to
fd81515
Compare
3 participants
No description provided.