[FIX] jakarta.mail.internet.ParseException: Unbalanced quoted string#3002
Open
chibenwa wants to merge 2 commits intoapache:masterfrom
Open
[FIX] jakarta.mail.internet.ParseException: Unbalanced quoted string#3002chibenwa wants to merge 2 commits intoapache:masterfrom
chibenwa wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A broken mail could not be taken out of the spooler and ended up being dead-lettered.
This simple fix makes it possible to process it.
Performance gain: in the fast path (source != null && !isBodyModified()), saveChanges() was called every time a mailet had modified a header — for example the Received: header added on reception. Yet
saveChanges():
...only to end up writing the already-in-memory headers (this.headers) and copying the body from the raw source unchanged. Completely wasted work.
The fast path was introduced precisely to avoid parsing the message. But the saveChanges() call was negating a large part of that benefit for every mail that had any header modified — which is essentially every mail James processes (at minimum the Received header is always added).
For large multipart messages with many attachments, the saving can be substantial.