Maven Parent 46 #11637
Merged
Maven Parent 46 #11637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w/ some slight updates
pom.xml
Outdated
Comment on lines
839
to
842
| <plugin> | ||
| <groupId>org.apache.rat</groupId> | ||
| <artifactId>apache-rat-plugin</artifactId> | ||
| </plugin> |
Member
There was a problem hiding this comment.
this should be inherited from parent 🤔
Member
Author
There was a problem hiding this comment.
I did not see it in parent, only in pluginMgmt... will doublecheck
pom.xml
Outdated
| <executions> | ||
| <execution> | ||
| <id>rat-check</id> | ||
| <configuration> |
Member
There was a problem hiding this comment.
in parent we have configuration on plugin level not on execution level ...
https://github.com/apache/maven-parent/blob/master/pom.xml#L1270
how it is merged? interesting
Member
Author
There was a problem hiding this comment.
Is merged as usual, but we can make this back to same as in parent (config and not exec level) to keep things less mind boggling.
Member
Author
There was a problem hiding this comment.
Reworked, now we have config only
slawekjaranowski
approved these changes
Jan 9, 2026
Bukama
approved these changes
Jan 10, 2026
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Jan 10, 2026
* Maven Parent 46 w/ some slight updates * Do run RAT on submodules * Fixes I missed parent rat in plugins Just alter config, nothing more
cstamas
added a commit
that referenced
this pull request
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w/ some slight updates