drivers/sensors: sensor bug fix - part 1#17824
Merged
Donny9 merged 3 commits intoapache:masterfrom Jan 19, 2026
Merged
Conversation
Otpvondoiats
requested review from
Donny9,
jerpelea and
xiaoxiang781216
as code owners
github-actions
bot
added
Area: Sensors
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
dd60fe3 to
6d1bebc
Compare
github-actions
bot
added
Area: OS Components
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
6d1bebc to
d510572
Compare
jerpelea
changed the title
jerpelea
previously approved these changes
Jan 12, 2026
Contributor
jerpelea
left a comment
jerpelea
left a comment
There was a problem hiding this comment.
please add "drivers/sensors:" in front of commit title
acassis
reviewed
Jan 12, 2026
Contributor
Author
|
wait for #17837 and apache/nuttx-apps#3312 |
linguini1
previously requested changes
Jan 12, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Ideally this could be three separate PRs since the commits seem unrelated.
We have conducted tests on the following platforms
Can you please provide more information about your testing? What did you test on the platforms, how do you know the behaviour is correct, etc.
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
d510572 to
94e3df0
Compare
Contributor
Author
|
depend on apache/nuttx-apps#3332 |
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
2 times, most recently
from
ad37cc7 to
a5b1d1b
Compare
Contributor
Author
done |
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
a5b1d1b to
ef9b878
Compare
xiaoxiang781216
approved these changes
Jan 16, 2026
linguini1
requested changes
Jan 16, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Can you please provide more information about your testing? What did you test on the platforms, how do you know the behaviour is correct, etc.
@xiaoxiang781216 as we voted in the mailing list, do not dismiss other reviewers comments please. I am always happy to re review.
Contributor
Author
Updated，You don't need to xiaoxiang781216， just contact me and I'll see your comments. |
Contributor
Author
|
This patch depends on apache/nuttx-apps#3332. I'll try modifying build.yaml to see if it can build successfully. |
Contributor
|
@Otpvondoiats please rebase your patch to the last master which conatain patch to fix the build break. |
linguini1
reviewed
Jan 17, 2026
linguini1
approved these changes
Jan 17, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
Looks good! Also, is the Unity test an internal tool?
acassis
approved these changes
Jan 17, 2026
Contributor
|
@Otpvondoiats please rebase your patch to the last master which fix the ci build break. |
Contributor
Author
yes，This includes basic functional tests for the sensor framework; |
The logic for obtaining the info and configuring the user buffer have been optimized. Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com> Signed-off-by: likun17 <likun17@xiaomi.com>
Fixes the issue of cross-core IPC being triggered when using O_DIRECT in non-cross-core scenarios. Signed-off-by: likun17 <likun17@xiaomi.com>
of driver information. When the local core is a virtual sensor, attempt to retrieve information from a remote core. Signed-off-by: likun17 <likun17@xiaomi.com>
Otpvondoiats
force-pushed
the
lk_fix_direct_flag
branch
from
ef9b878 to
e5d54d9
Compare
Contributor
Author
Done |
Contributor
Author
|
I pushed it again, and then a case failed. I built it locally, posted the logs, and then merged it. |
Donny9
approved these changes
Jan 19, 2026
Contributor
Author
|
I compiled sim:rpserver_virtio locally, and the local compilation succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Cross-core direct connection and cross-core information retrieval
Testing
uniy test