arch/arm/samv7: fix incorrect Kconfig SAMV7_EMAC0_RMII dependency#17832
Merged
simbit18 merged 1 commit intoapache:masterfrom Jan 15, 2026
Merged
arch/arm/samv7: fix incorrect Kconfig SAMV7_EMAC0_RMII dependency#17832simbit18 merged 1 commit intoapache:masterfrom
simbit18 merged 1 commit intoapache:masterfrom
Conversation
github-actions
bot
added
Arch: arm
Contributor
|
@raiden00pl @szafonimateusz-mi problems on the step # get NTFC test cases here too |
simbit18
requested review from
acassis,
linguini1,
raiden00pl and
xiaoxiang781216
Member
|
@simbit18 It seems that github actions doesn't work well with ubuntu mirrors, I'll try another approach to install venv |
jerpelea
changed the title
jerpelea
approved these changes
Jan 12, 2026
Member
xiaoxiang781216
approved these changes
Jan 12, 2026
linguini1
approved these changes
Jan 12, 2026
Contributor
|
@michallenc please rebase the latest master |
SAMV7_EMAC0_RMII should not depend on ARCH_CHIP_SAM4E as this is a completely different chip. This is likely a relict from copying the code base. Signed-off-by: Michal Lenc <michallenc@seznam.cz>
michallenc
force-pushed
the
samv7-kconfig-rmii-fix
branch
from
e0368d6 to
f1a54a3
Compare
Contributor
Author
|
Sorry for the delay, rebased |
xiaoxiang781216
approved these changes
Jan 15, 2026
simbit18
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SAMV7_EMAC0_RMIIshould not depend onARCH_CHIP_SAM4Eas this is a completely different chip. This is likely a relict from copying the code base.Impact
None as
ARCH_CHIP_SAM4Ecan't be set anyway if SAMv7 chip is used.