drivers/analog: fix adc ads1115 driver #18286
Open
+19
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikimari
force-pushed
the
fix-ads1115-driver
branch
from
f52327d to
433289e
Compare
Signed-off-by: Ari Kimari <[email protected]> Fix write reg to work with all platforms Fix compile warnings
Contributor
|
@arikimari please fix: ❌ Missing git commit message |
arikimari
force-pushed
the
fix-ads1115-driver
branch
from
433289e to
44dac4b
Compare
linguini1
requested changes
Jan 30, 2026
Contributor
linguini1
left a comment
linguini1
left a comment
There was a problem hiding this comment.
The change is good, but please provide some information about how you tested and some logs of the results.
xiaoxiang781216
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix reg write function so that it works with all platfroms
no need for to two separate i2c messages
Remove one unused static function (causing compile warning)
Fix documentation of channels
Impact
Platforms using ads1115 driver from Nuttx
Testing
Custom nxp93 hw with ads1115 adc