HDDS-16004. Return NotImplemented for GetObjectTorrent instead of GetObject body - #10899
Open
shuan1026 wants to merge 1 commit into
Open
HDDS-16004. Return NotImplemented for GetObjectTorrent instead of GetObject body#10899shuan1026 wants to merge 1 commit into
shuan1026 wants to merge 1 commit into
Conversation
Author
|
PTAL @chungen0126 Thank you! |
chihsuan
approved these changes
Aug 1, 2026
chihsuan
left a comment
chihsuan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch! @shuan1026 LGTM +1.
chungen0126
reviewed
Aug 3, 2026
chungen0126
left a comment
chungen0126
left a comment
Contributor
There was a problem hiding this comment.
Thanks @shuan1026 for working on this. Please also add test to AbstractS3SDKV1Tests and AbstractS3SDKV2Tests.
Contributor
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Ozone S3G does not support GetObjectTorrent (
GET ...?torrent). Currently the request falls through to GetObject and returns 200 OK with the raw object bytes, which misleads clients and fails ceph s3-teststest_get_object_torrent(assert data != _get_body(response)when the body matches the uploaded payload).This PR mirrors
BucketGetLocationHandler: registerObjectGetTorrentHandlerfirst on the object GET chain, detect?torrent, and return501 NotImplementedbefore GetObject runs. BitTorrent/bencode generation is out of scope.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16004
How was this patch tested?
mvn -pl :ozone-s3gateway test -Dtest=TestObjectGetTorrent,TestObjectGetozone-s3gatewaytest module (701 tests, no regressions)checkstyle.sh(0 violations)