HDDS-16034. Certificates omit DNS SANs on clusters with non-public hostname suffixes - #10908
Open
ss77892 wants to merge 1 commit into
Open
HDDS-16034. Certificates omit DNS SANs on clusters with non-public hostname suffixes#10908ss77892 wants to merge 1 commit into
ss77892 wants to merge 1 commit into
Conversation
…stname suffixes Co-authored-by: Claude Code (Claude Opus 5)
adoroszlai
changed the title
Contributor
Author
|
The failure is not related to the fix and passed here https://github.com/ss77892/ozone/actions/runs/30554604238 |
Contributor
Author
|
@fapifta Thank you for the review. The failure is still unrelated. Filed HDDS-16081 for that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
PR replaces the public-suffix test with an RFC 1123 hostname syntax check in a shared helper, applied symmetrically by both builders and by the CA. Internal suffixes and single-label names become legal; malformed, wildcard, and IP-literal values stay rejected. No new configuration key and no wire change. Certificates on public-suffix clusters are unchanged and need no reissue.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-16034
How was this patch tested?