Skip to content

HDDS-16065. Fix flaky testCloseNonStreamablePipelineThenStream #10927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adoroszlai wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

HDDS-16065. Fix flaky testCloseNonStreamablePipelineThenStream #10927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...est/src/test/java/org/apache/hadoop/fs/ozone/TestOzoneFileSystemDataStreamEnablement.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,11 @@ private List<Pipeline> openRatisThreePipelines() {
Pipeline.PipelineState.OPEN);
}

private static boolean noNodesHaveDatastreamPort(Pipeline pipeline) {
return pipeline.getNodes().stream()
.noneMatch(n -> n.hasPort(RATIS_DATASTREAM));
}

private static boolean allNodesHaveDatastreamPort(Pipeline pipeline) {
return pipeline.getNodes().stream()
.allMatch(n -> n.hasPort(RATIS_DATASTREAM));
Expand Down Expand Up @@ -336,7 +341,7 @@ public void testCloseNonStreamablePipelineThenStream() throws Exception {
}
final List<Pipeline> before = openRatisThreePipelines();
assertFalse(before.isEmpty());
before.forEach(p -> assertFalse(allNodesHaveDatastreamPort(p),
before.forEach(p -> assertTrue(noNodesHaveDatastreamPort(p),
"pipeline should be portless before enabling datastream"));

rollingRestartEnablingDataStream();
Expand All @@ -350,8 +355,8 @@ public void testCloseNonStreamablePipelineThenStream() throws Exception {
final PipelineManagerImpl pipelineManager =
(PipelineManagerImpl) cluster.getStorageContainerManager().getPipelineManager();
final List<Pipeline> reloaded = openRatisThreePipelines();
assertFalse(reloaded.isEmpty());
reloaded.forEach(p -> assertFalse(allNodesHaveDatastreamPort(p),
reloaded.retainAll(before);
reloaded.forEach(p -> assertTrue(noNodesHaveDatastreamPort(p),
"reloaded pipeline should still be portless"));

// Close the pipeline(s) exposing the new datastream port; a fresh
Expand Down
Loading