-
Notifications
You must be signed in to change notification settings - Fork 594
HDDS-14352. [doc] Add proxy user configuration documentation to HttpFS #9596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-14352. [doc] Add proxy user configuration documentation to HttpFS #9596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR addresses a documentation gap by adding comprehensive proxy user configuration documentation to the HttpFS interface guide. The documentation explains how to configure user impersonation, which is essential when HttpFS is used as a gateway.
- Added complete proxy user configuration section with explanations, examples, and troubleshooting guidance
- Included XML configuration examples for
httpfs.proxyuser.#USER#.hostsandhttpfs.proxyuser.#USER#.groupsproperties - Provided troubleshooting section to help users diagnose common impersonation errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dombizita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for picking this up @smengcl! Based on your comment #9574 (reply in thread) this is AI generated, could you please add Generated-by: ... to the PR description and commit message? (ASF Generative Tooling Guidance)
This should be included as a token in the source control commit message, for example including the phrase “Generated-by: ”
Thank you!
|
@sinedTr would you like to take a look at this? |
|
@dombizita : I left a comment on one of the suggested changes, other than that I agree with this PR |
dombizita
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I committed two small changes, let me know what you think of it @smengcl!
jojochuang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Merged. Thanks @dombizita @smengcl @sinedTr |
|
Thanks @dombizita @sinedTr @jojochuang for the reviews! |
@dombizita Good catch, that should be added. We also could have added that when right before merging it to the branch but looks like we missed it this time. Oh well. |
What changes were proposed in this pull request?
Documentation gap: #9574
httpfs.proxyuser.USER.hostsandhttpfs.proxyuser.USER.groupsare required to configure httpfs proxyuser.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14352
How was this patch tested?