Skip to content

Conversation

@smengcl
Copy link
Contributor

@smengcl smengcl commented Jan 6, 2026

What changes were proposed in this pull request?

Documentation gap: #9574

httpfs.proxyuser.USER.hosts and httpfs.proxyuser.USER.groups are required to configure httpfs proxyuser.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-14352

How was this patch tested?

  • n/a

@smengcl smengcl added documentation Improvements or additions to documentation AI-gen labels Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a documentation gap by adding comprehensive proxy user configuration documentation to the HttpFS interface guide. The documentation explains how to configure user impersonation, which is essential when HttpFS is used as a gateway.

  • Added complete proxy user configuration section with explanations, examples, and troubleshooting guidance
  • Included XML configuration examples for httpfs.proxyuser.#USER#.hosts and httpfs.proxyuser.#USER#.groups properties
  • Provided troubleshooting section to help users diagnose common impersonation errors

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up @smengcl! Based on your comment #9574 (reply in thread) this is AI generated, could you please add Generated-by: ... to the PR description and commit message? (ASF Generative Tooling Guidance)

This should be included as a token in the source control commit message, for example including the phrase “Generated-by: ”

Thank you!

@dombizita
Copy link
Contributor

@sinedTr would you like to take a look at this?

@sinedTr
Copy link

sinedTr commented Jan 8, 2026

@dombizita : I left a comment on one of the suggested changes, other than that I agree with this PR

Copy link
Contributor

@dombizita dombizita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I committed two small changes, let me know what you think of it @smengcl!

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jojochuang jojochuang merged commit 643b80a into apache:master Jan 13, 2026
15 checks passed
@jojochuang
Copy link
Contributor

Merged. Thanks @dombizita @smengcl @sinedTr

@smengcl
Copy link
Contributor Author

smengcl commented Jan 13, 2026

Thanks @dombizita @sinedTr @jojochuang for the reviews!

@smengcl
Copy link
Contributor Author

smengcl commented Jan 13, 2026

This should be included as a token in the source control commit message, for example including the phrase “Generated-by: ”

@dombizita Good catch, that should be added.

We also could have added that when right before merging it to the branch but looks like we missed it this time. Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-gen documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants