[spark] Refactor PaimonSparkWriter write flow#8417
Open
huangxiaopingRD wants to merge 5 commits into
Open
Conversation
Contributor
|
cc @Zouxxyy |
JingsongLi
reviewed
Jul 3, 2026
| batchId: Option[Long] = None) | ||
| extends WriteHelper { | ||
|
|
||
| private case class WriteContext( |
Contributor
There was a problem hiding this comment.
The task closures below capture this whole WriteContext via ctx.newWrite() / ctx.bucketColIdx. Because the context also stores driver-side objects (SparkSession, the original DataFrame, and preparedData), those objects become part of every executor closure even though they are only needed while building the plan on the driver. This can make Spark closure serialization fail or drag SparkContext/Dataset state into tasks. Please keep WriteContext limited to serializable task inputs, or extract only the needed scalars/functions before mapPartitions and keep SparkSession/DataFrame out of the captured object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Refactor
PaimonSparkWriterto make the Spark write flow easier to follow without changing write semantics.This change mainly:
writeinto dedicated private methodsTests
Not adding new tests.
Reason: