Skip to content

Mark shredded_variant cases 41, 131, 132, 138 as INVALID (missing 'value' column) #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jul 22, 2026
Merged

Mark shredded_variant cases 41, 131, 132, 138 as INVALID (missing 'value' column) #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 shredded_variant/case-041.parquet → shredded_variant/case-041-INVALID.parquet
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-041_row-0.variant.bin → ...ariant/case-041-INVALID_row-0.variant.bin
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-131.parquet → shredded_variant/case-131-INVALID.parquet
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-131_row-0.variant.bin → ...ariant/case-131-INVALID_row-0.variant.bin
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-132.parquet → shredded_variant/case-132-INVALID.parquet
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-132_row-0.variant.bin → ...ariant/case-132-INVALID_row-0.variant.bin
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-138.parquet → shredded_variant/case-138-INVALID.parquet
View file
Open in desktop
File renamed without changes.
0 shredded_variant/case-138_row-0.variant.bin → ...ariant/case-138-INVALID_row-0.variant.bin
View file
Open in desktop
File renamed without changes.
20 changes: 12 additions & 8 deletions shredded_variant/cases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,9 @@
}, {
"case_number" : 41,
"test" : "testArrayMissingValueColumn",
"parquet_file" : "case-041.parquet",
"variant_file" : "case-041_row-0.variant.bin",
"notes" : "This parquet file is not valid according to the spec (the variant group omits the required 'value' column) and implementations can choose to error, or read the shredded value",
"parquet_file" : "case-041-INVALID.parquet",
"variant_file" : "case-041-INVALID_row-0.variant.bin",
"variant" : "Variant(metadata=VariantMetadata(dict={}), value=VariantArray([Variant(type=STRING, value=comedy), Variant(type=STRING, value=drama)]))"
}, {
"case_number" : 42,
Expand Down Expand Up @@ -775,14 +776,16 @@
}, {
"case_number" : 131,
"test" : "testMissingValueColumn",
"parquet_file" : "case-131.parquet",
"variant_file" : "case-131_row-0.variant.bin",
"notes" : "This parquet file is not valid according to the spec (the variant group omits the required 'value' column) and implementations can choose to error, or read the shredded value",
"parquet_file" : "case-131-INVALID.parquet",
"variant_file" : "case-131-INVALID_row-0.variant.bin",
"variant" : "Variant(metadata=VariantMetadata(dict={}), value=Variant(type=INT32, value=34))"
}, {
"case_number" : 132,
"test" : "testShreddedObjectMissingFieldValueColumn",
"parquet_file" : "case-132.parquet",
"variant_file" : "case-132_row-0.variant.bin",
"notes" : "This parquet file is not valid according to the spec (the shredded object field groups omit the required 'value' column) and implementations can choose to error, or read the shredded value",
"parquet_file" : "case-132-INVALID.parquet",
"variant_file" : "case-132-INVALID_row-0.variant.bin",
"variant" : "Variant(metadata=VariantMetadata(dict={0 => a, 1 => b, 2 => c, 3 => d, 4 => e}), value=VariantObject(fields={b: Variant(type=STRING, value=iceberg)}))"
}, {
"case_number" : 133,
Expand Down Expand Up @@ -816,7 +819,8 @@
}, {
"case_number" : 138,
"test" : "testShreddedObjectMissingValueColumn",
"parquet_file" : "case-138.parquet",
"variant_file" : "case-138_row-0.variant.bin",
"notes" : "This parquet file is not valid according to the spec (the variant group omits the required 'value' column) and implementations can choose to error, or read the shredded value",
"parquet_file" : "case-138-INVALID.parquet",
"variant_file" : "case-138-INVALID_row-0.variant.bin",
"variant" : "Variant(metadata=VariantMetadata(dict={0 => a, 1 => b, 2 => c, 3 => d, 4 => e}), value=VariantObject(fields={a: Variant(type=INT16, value=1234), b: Variant(type=STRING, value=iceberg)}))"
} ]