PHOENIX-7993: Move PhoenixSyncTableOutputRepositoryTest class as an Integration test - #2610
Open
rahulLiving wants to merge 15 commits into
Open
PHOENIX-7993: Move PhoenixSyncTableOutputRepositoryTest class as an Integration test#2610rahulLiving wants to merge 15 commits into
rahulLiving wants to merge 15 commits into
Conversation
rahulLiving
changed the title
There was a problem hiding this comment.
🟢 Approval recommended
The changes are a straightforward test reclassification/relocation with consistent package, naming, and category usage for IT execution.
Pull request overview
This PR aligns a mini-cluster-based test with Phoenix’s integration test structure by moving it into the end2end IT suite and updating naming/annotations accordingly.
Changes:
- Updated the test’s package to
org.apache.phoenix.end2endto match its IT location. - Renamed the test class from
PhoenixSyncTableOutputRepositoryTesttoPhoenixSyncTableOutputRepositoryIT. - Marked the test with
@Category(NeedsOwnMiniClusterTest.class)to ensure it runs in the appropriate mini-cluster execution group.
File summaries
| File | Description |
|---|---|
| phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixSyncTableOutputRepositoryIT.java | Renames/repackages the test as an integration test and adds the mini-cluster category annotation. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Moving a unit test which spins up Mini cluster as IntegrationTest
Why are the changes needed?
Since all Mini cluster test belong to IT
Does this PR introduce any user-facing change?
How was this patch tested?
Ran test locally
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude-4.7