fix(plc4j/eip): fix ConnectionManager - #2673
Merged
chrisdutz merged 1 commit intoAug 10, 2026
Merged
Conversation
connectionSerialNumber is out of range to establish connection add missing encoding for unsigned integers to reading tags
19 tasks
chrisdutz
requested changes
Aug 5, 2026
chrisdutz
approved these changes
Aug 6, 2026
chrisdutz
left a comment
chrisdutz
left a comment
Contributor
There was a problem hiding this comment.
Was already Ok .... no Idea what I saw there last time ;-)
Contributor
|
Argh!!!! ... stupid signatures :-( (I think we're stalled here till that "feature" is turned off again :-( ) |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes EtherNet/IP (EIP) connection establishment and tag decoding by ensuring protocol fields are encoded/decoded with the correct unsigned integer settings, and by constraining the Connection Manager connectionSerialNumber to a valid 16-bit range.
Changes:
- Generate
connectionSerialNumberwithin a 16-bit unsigned range to avoid out-of-range serialization when opening/closing connections. - Use the existing
EipTcpMessageCodecbuffer factories when encoding tag paths and decoding multi-service responses, ensuring consistent byte order and unsigned integer encoding.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field connectionSerialNumber is out of range to establish connection
Add missing encoding for unsigned integers to reading tags