[fix][broker] Close protocol handlers channel

[gaozhangmin]

Motivation

During the shutdown process of Pulsar brokers, protocol handlers' channels are not properly closed, which allows new client requests to continue arriving even after the shutdown has been initiated. This can lead to:

• Resource leaks as channels remain open during shutdown
• Unexpected behavior where clients can still send requests to a shutting-down broker
• Inconsistent shutdown behavior compared to the main broker channel management

The broker's closeAsync method properly handles closing all channels by calling channel.close() on all channels in listChannels. However, the same pattern is not applied to protocol handlers, leaving their channels open during the shutdown process.

Modifications

• Added closeProtocolHandlerChannels() method to properly close all protocol handler channels before calling protocolHandler.close()
• Modified the broker shutdown sequence to ensure protocol handler channels are closed before the protocol handler itself is closed
• This ensures no new client connections can be established to protocol handlers during the shutdown process
• Follows the same pattern as the existing broker channel closing mechanism in closeAsync

Verifying this change

• Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as:

• Existing broker shutdown tests will verify the proper shutdown sequence
• Protocol handler lifecycle tests will ensure channels are properly closed
• Connection management tests will verify no new connections are accepted during shutdown

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment - Changes broker shutdown behavior which affects deployment lifecycle

Documentation

[

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

gaozhangmin#14

[BewareMyPower]

It should be called after protocolHandlers.close() because the close method of protocol handler might do some cleanup jobs that rely on the connection.

[lhotari]

@BewareMyPower I think that it should be fine to close the channels before protocol handlers. The reason for this is that the channels that are being closed are ServerChannel instances and wouldn't impact existing connections. Closing the ServerChannels will prevent new connections being opened.

[BewareMyPower]

Protocol handlers close before the ownership change in BrokerService#unloadNamespaceBundlesGracefully. Even if you close the channels before closing the protocol handler, the requests could still be sent to the broker and rejected. It's actually worse because no logs can be found at broker side.

[lhotari]

LGTM