Skip to content

[ISSUE #10035] Fix: avoid extra padding when message end position is already page-al…#10036

Merged
RongtongJin merged 1 commit intoapache:developfrom
guyinyou:dev_fix_tail_alignment
Jan 21, 2026
Merged

[ISSUE #10035] Fix: avoid extra padding when message end position is already page-al…#10036
RongtongJin merged 1 commit intoapache:developfrom
guyinyou:dev_fix_tail_alignment

Conversation

@guyinyou
Copy link
Contributor

…igned

Change-Id: I3e7fad9c4b194b20015414bcceb830760df68fea

Which Issue(s) This PR Fixes

Fixes #10035

Brief Description

How Did You Test This Change?

…igned

Change-Id: I3e7fad9c4b194b20015414bcceb830760df68fea
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.89%. Comparing base (4aa6cdd) to head (984d394).

Files with missing lines Patch % Lines
...ache/rocketmq/store/logfile/DefaultMappedFile.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10036      +/-   ##
=============================================
+ Coverage      48.86%   48.89%   +0.02%     
- Complexity     13326    13330       +4     
=============================================
  Files           1373     1373              
  Lines          99698    99700       +2     
  Branches       12886    12887       +1     
=============================================
+ Hits           48720    48747      +27     
+ Misses         45053    45032      -21     
+ Partials        5925     5921       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin merged commit 236ede2 into apache:develop Jan 21, 2026
11 of 12 checks passed
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request Feb 10, 2026
…igned (apache#10036)

Change-Id: I3e7fad9c4b194b20015414bcceb830760df68fea

Co-authored-by: guyinyou <guyinyou.gyy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix page alignment boundary case in DefaultMappedFile

3 participants

Comments