Skip to content

[ISSUE #10046] Fix lock leak risk in sendHeartbeatToBroker#10047

Merged
RongtongJin merged 1 commit intoapache:developfrom
yx9o:dev-10046
Feb 5, 2026
Merged

[ISSUE #10046] Fix lock leak risk in sendHeartbeatToBroker#10047
RongtongJin merged 1 commit intoapache:developfrom
yx9o:dev-10046

Conversation

@yx9o
Copy link
Contributor

@yx9o yx9o commented Jan 25, 2026

Fixes #10046 .

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.90%. Comparing base (50e7ffa) to head (ae7a0c3).

Files with missing lines Patch % Lines
...rocketmq/client/impl/factory/MQClientInstance.java 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop   #10047      +/-   ##
=============================================
- Coverage      48.96%   48.90%   -0.07%     
+ Complexity     13355    13337      -18     
=============================================
  Files           1373     1373              
  Lines          99700    99700              
  Branches       12887    12887              
=============================================
- Hits           48820    48758      -62     
- Misses         44974    45024      +50     
- Partials        5906     5918      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RongtongJin RongtongJin merged commit a6c5604 into apache:develop Feb 5, 2026
11 of 13 checks passed
@yx9o yx9o deleted the dev-10046 branch February 5, 2026 10:00
dingshuangxi888 pushed a commit to dingshuangxi888/rocketmq that referenced this pull request Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Fix lock leak risk in sendHeartbeatToBroker

3 participants