fix(store): close all consume queue file handles on ConsumeQueueStore shutdown#10060
Merged
ltamber merged 2 commits intoapache:developfrom Feb 2, 2026
Merged
fix(store): close all consume queue file handles on ConsumeQueueStore shutdown#10060ltamber merged 2 commits intoapache:developfrom
ltamber merged 2 commits intoapache:developfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #10060 +/- ##
=============================================
- Coverage 48.96% 48.85% -0.11%
+ Complexity 13359 13331 -28
=============================================
Files 1373 1373
Lines 99743 99747 +4
Branches 12888 12888
=============================================
- Hits 48837 48736 -101
- Misses 44996 45090 +94
- Partials 5910 5921 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ltamber
approved these changes
Feb 2, 2026
dingshuangxi888
pushed a commit
to dingshuangxi888/rocketmq
that referenced
this pull request
Feb 10, 2026
… shutdown (apache#10060) * fix(store): close all consume queue file handles on ConsumeQueueStore shutdown * remove implementation --------- Co-authored-by: RongtongJin <user@example.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Fixes #issue_id
Brief Description
How Did You Test This Change?