[DOCS] Set site_url so language switcher links include the base path#110
Merged
Conversation
Without site_url, mkdocs-static-i18n generates alternate-language links rooted at the domain, so the 中文 option in the header pointed to https://sedona.apache.org/zh/ (404) instead of https://sedona.apache.org/spatialbench/zh/. Setting site_url also makes Material emit correct canonical and sitemap URLs. Fixes #109
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
What changes were proposed in this PR?
Add
site_url: https://sedona.apache.org/spatialbench/tomkdocs.yml.Without
site_url, themkdocs-static-i18nplugin generates the header language-switcher links rooted at the domain, so the 中文 option pointed tohttps://sedona.apache.org/zh/(404) instead ofhttps://sedona.apache.org/spatialbench/zh/. Settingsite_urlalso makes Material emit correct<link rel="canonical">tags and sitemap URLs.How was this patch tested?
Built the docs locally with the full plugin stack and inspected the generated HTML:
/spatialbench/(English) and/spatialbench/zh/(中文) on both the English and Chinese pages.https://sedona.apache.org/spatialbench/andhttps://sedona.apache.org/spatialbench/zh/.