Skip to content

SOLR-18140: Try to bandaid the DELETENODE docs for a broken API #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epugh merged 2 commits into from
Mar 17, 2026
+7 −2
Merged

SOLR-18140: Try to bandaid the DELETENODE docs for a broken API #4170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f543a3
I think this API is bad, it doesnt delete a node, it deletes replicas…
epugh Feb 27, 2026
f671460
Update solr/solr-ref-guide/modules/deployment-guide/pages/cluster-nod…
epugh Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions solr/solr-ref-guide/modules/deployment-guide/pages/cluster-node-management.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ Examining the clusterstate after issuing this call should show exactly one repli
== Migrate Replicas

Migrate all replicas off of a given set of source nodes.
+

If more than one node is used as a targetNode (either explicitly, or by default), then the configured
xref:configuration-guide:replica-placement-plugins.adoc[Replica Placement Plugin] will be used to determine
which targetNode should be used for each migrated replica.
Expand Down Expand Up @@ -862,7 +862,12 @@ So don't perform other collection operations in this period.
== DELETENODE: Delete Replicas in a Node

Deletes all replicas of all collections in that node.
Please note that the node itself will remain as a live node after this operation.
Please note that the node itself will remain as a live node after this operation if it is currently functioning.

[TIP]
====
If the node is currently down and you aren't bringing it back, then this command removes that node's replica entries from the cluster state (ZooKeeper), cleaning up references to its replicas. It does not change the node's liveness in `/live_nodes`, and the node may still rejoin the cluster if it is started again later.
Copy link
Copy Markdown
Contributor

@HoustonPutman HoustonPutman Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part isn't really necessary

If the node is currently down and you aren't bring it back

Because this part is applicable whether the node is down or up

this command removes that node's replica entries from the cluster state (ZooKeeper), cleaning up references to its replicas. It does not change the node's liveness in /live_nodes

I guess maybe the command is poorly named, but there is no idea of a persistent node in Solr, only something that has connected to the cluster and registered in live nodes...

Copy link
Copy Markdown
Contributor Author

@epugh epugh Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to look at the text from your more knowlagable perspective? Do we cover in the Ref Guide this "no idea of a persistent node"? The part I struggle with is that the Nodes UI shows "down nodes"... Which makes you think they will come back. However, what makes a node "down" is that a replica for a collection just happens to be living on it.... I am struggling to convey that better...

Would adding to https://solr.apache.org/guide/solr/latest/deployment-guide/cluster-types.html#solrcloud-mode a "Nodes" header that explains this be helpful?

====

[tabs#deletenode-request]
======
Expand Down
Loading