Skip to content

SOLR-18089: Configure zookeeper.maxCnxns for embeddedZkServer #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsmiley merged 2 commits into from
Mar 9, 2026
Merged

SOLR-18089: Configure zookeeper.maxCnxns for embeddedZkServer #4173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd877a
SOLR-18089: Configure zookeeper.maxCnxns for embeddedZkServer
kamlendrachauhan Mar 1, 2026
427de70
SOLR-18089: Address review feedback for embeddedZkServer
kamlendrachauhan Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions solr/core/src/java/org/apache/solr/cloud/SolrZkServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ public class SolrZkServer {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());

public static final String ZK_WHITELIST_PROPERTY = "zookeeper.4lw.commands.whitelist";
public static final String ZK_MAX_CNXNS_PROPERTY = "zookeeper.maxCnxns";
// Per ZooKeeper, "0" means no limit for max client connections.
public static final String ZK_MAX_CNXNS_DEFAULT = "0";
Copy link
Copy Markdown
Contributor

@dsmiley dsmiley Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment what this value semantically means. Infinite?


boolean zkRun = false;
String zkHost;
Expand Down Expand Up @@ -138,6 +141,7 @@ public void start() {
return;
}

ensureZkMaxCnxnsConfigured();
if (System.getProperty(ZK_WHITELIST_PROPERTY) == null) {
System.setProperty(ZK_WHITELIST_PROPERTY, "ruok, mntr, conf");
}
Expand Down Expand Up @@ -208,6 +212,10 @@ public void stop() {
}
zkThread.interrupt();
}

static void ensureZkMaxCnxnsConfigured() {
System.getProperties().putIfAbsent(ZK_MAX_CNXNS_PROPERTY, ZK_MAX_CNXNS_DEFAULT);
}
}

// Allows us to set a default for the data dir before parsing
Expand Down
1 change: 1 addition & 0 deletions solr/test-framework/src/java/org/apache/solr/cloud/ZkTestServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,7 @@ public void run() throws InterruptedException, IOException {

public void run(boolean solrFormat) throws InterruptedException, IOException {
log.info("STARTING ZK TEST SERVER");
SolrZkServer.ensureZkMaxCnxnsConfigured();
ensureStatCommandWhitelisted();

AtomicReference<Throwable> zooError = new AtomicReference<>();
Expand Down
Loading