SOLR-17550: preferred Overseer might not work#4175
Open
r4mercur wants to merge 4 commits intoapache:mainfrom
Open
SOLR-17550: preferred Overseer might not work#4175r4mercur wants to merge 4 commits intoapache:mainfrom
r4mercur wants to merge 4 commits intoapache:mainfrom
Conversation
add testcase to identify wrong method behaviour of setPreferredOverseer() in ZkController
fix import after ./gradlew check & ./gradlew tidy
fix import after ./gradlew check & ./gradlew tidy & change test
./gradlew tidy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add testcase to identify wrong method behaviour of setPreferredOverseer() in ZkController
https://issues.apache.org/jira/browse/SOLR-17550
Description
Like described in the ticket from the reporter: "By code inspection, ZkController.setPreferredOverseer creates a command message improperly. The key "node" should exist with the node name as value but instead the key is itself the node name – a bug introduced by a refactoring in 2022.
Ideally we understand the ramifications; like shouldn't this be found by a test?"
I only added the test case currently, not sure if the bug should also be fixed by using "node" as static string as key ?
Solution
My approach is a new unittest-case to identify the wrong behaviour of the setter method in the ZkController. I used the LLM "Claude Sonet 4.5" for problem description and solution proposals.
Tests
The new unittest-case written should identify problems, when using "getNodeName()" to set the key of the properties.
Checklist
Please review the following and check all that apply:
mainbranch../gradlew check.