[SPARK-56317][SQL] GetJsonObjectEvaluator should reuse output buffer#55134
Open
leixm wants to merge 1 commit intoapache:masterfrom
Open
[SPARK-56317][SQL] GetJsonObjectEvaluator should reuse output buffer#55134leixm wants to merge 1 commit intoapache:masterfrom
leixm wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
cc @LuciferYang @panbingkun , Can you help review? |
LuciferYang
changed the title
LuciferYang
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
GetJsonObjectEvaluator should reuse output buffer.
Why are the changes needed?
Currently, GetJsonObjectEvaluator.evaluate() creates a new ByteArrayOutputStream on every invocation. Since the evaluator is reused across rows, this results in unnecessary object allocation and GC pressure. We can reuse the output buffer by promoting it to a class-level lazy val and calling reset() before each use, this is consistent with StructsToJsonEvaluator, which reuses a CharArrayWriter across rows.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No.