Skip to content

[SPARK-58894][SQL] Detect cyclic view references in nested subqueries #58146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manuzhang wants to merge 1 commit into from
+15 −2
Closed

[SPARK-58894][SQL] Detect cyclic view references in nested subqueries #58146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,9 +599,9 @@ object ViewHelper extends SQLConfHelper with Logging with CapturesConfig {
plan.children.foreach(child => checkCyclicViewReference(child, path, viewIdent))
}

// Detect cyclic references from subqueries.
// Detect cyclic references from subqueries nested in expressions.
plan.expressions.foreach { expr =>
expr match {
expr.foreach {
case s: SubqueryExpression =>
checkCyclicViewReference(s.plan, path, viewIdent)
case _ => // Do nothing.
Expand Down
13 changes: 13 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1018,6 +1018,19 @@ abstract class SQLViewSuite extends QueryTest {
s"`$SESSION_CATALOG_NAME`.`default`.`view2` -> " +
s"`$SESSION_CATALOG_NAME`.`default`.`view1`"))
)

// Detect cyclic view references from subqueries nested in larger expressions.
checkError(
exception = intercept[AnalysisException] {
sql("ALTER VIEW view1 AS SELECT * FROM jt WHERE id = (SELECT id FROM view2)")
},
condition = "RECURSIVE_VIEW",
parameters = Map(
"viewIdent" -> s"`$SESSION_CATALOG_NAME`.`default`.`view1`",
"newPath" -> (s"`$SESSION_CATALOG_NAME`.`default`.`view1` -> " +
s"`$SESSION_CATALOG_NAME`.`default`.`view2` -> " +
s"`$SESSION_CATALOG_NAME`.`default`.`view1`"))
)
}
}

Expand Down