[SPARK-59273][SQL][FOLLOWUP] Cover string fill with mixed schemas - #58682
Open
zhangxinyao88 wants to merge 1 commit into
Open
[SPARK-59273][SQL][FOLLOWUP] Cover string fill with mixed schemas#58682zhangxinyao88 wants to merge 1 commit into
zhangxinyao88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extend the existing SPARK-59273 CHAR/VARCHAR
na.fill("x")test with an integer column.The test verifies that string fill values still fill CHAR and VARCHAR columns, while a non-string column is left unchanged.
Why are the changes needed?
SPARK-59273 broadened string matching to include the CHAR/VARCHAR family. The follow-up fix in #58646 restored skipping non-string columns.
The existing tests cover those behaviors separately. This test covers the mixed-schema case directly, so a future change cannot reintroduce the interaction that caused the regression.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The targeted test was started locally, but its first-run SQL test compilation was interrupted before execution completed. GitHub Actions will run the full suite.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)