Skip to content

fix: Prevent list modification during iteration in BrowserPool #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vdusek wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

fix: Prevent list modification during iteration in BrowserPool #1703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/crawlee/browsers/_browser_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,14 +346,14 @@ async def _launch_new_browser(self, plugin: BrowserPlugin) -> BrowserController:

def _identify_inactive_browsers(self) -> None:
"""Identify inactive browsers and move them to the inactive list if their idle time exceeds the threshold."""
for browser in self._active_browsers:
for browser in list(self._active_browsers):
if browser.idle_time >= self._browser_inactive_threshold:
self._active_browsers.remove(browser)
self._inactive_browsers.append(browser)

async def _close_inactive_browsers(self) -> None:
"""Close the browsers that have no active pages and have been idle for a certain period."""
for browser in self._inactive_browsers:
for browser in list(self._inactive_browsers):
if not browser.pages:
await browser.close()
self._inactive_browsers.remove(browser)
Loading