feat: add is_finished method to RequestQueueClient interface#1982
Open
Mantisus wants to merge 6 commits into
Open
feat: add is_finished method to RequestQueueClient interface#1982Mantisus wants to merge 6 commits into
is_finished method to RequestQueueClient interface#1982Mantisus wants to merge 6 commits into
Conversation
janbuchar
reviewed
Jun 22, 2026
janbuchar
left a comment
janbuchar
left a comment
Collaborator
There was a problem hiding this comment.
Looks sound, the only thing I'm mildly concerned about is the removal of the is_empty return value caching — I'd feel better if I knew some historical context and why it's safe to do this.
vdusek
reviewed
Jun 22, 2026
vdusek
left a comment
vdusek
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! Could you please implement apify/apify-sdk-python#987 as well?
That way, we can verify that it works on the platform too.
I'd like this to be part of SDK v4, built on top of Crawlee v1.8 with this included.
Collaborator
Author
Sure. |
vdusek
requested changes
Jun 23, 2026
Co-authored-by: Vlada Dusek <v.dusek96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
is_finishedmethod to theRequestQueueClientinterface. It's not a breaking change. The base class defaultsis_finishedtois_emptywhen it isn't overridden. Splits the queue predicates.is_emptymeans there are no requests available to fetch.is_finishedmeans all requests are fully processed (nothing to fetch and nothing in progress).is_finishedin all built-inRequestQueueClient.is_emptyin all built-inRequestQueueClientto match the new meaning.AutoscaledPool. It now skips scheduling new tasks when no requests are available to fetch. For example, while the only request is being processed.Issues
is_finishedmethod to theStorageClientinterface #1966Testing
RequestQueuethat checks theis_emptyandis_finishedvalues through the queue lifecycle. It covers all built-in clients.AutoscaledPooldoesn't schedule new tasks while the only request is being processed.