fix(system): Handle psutil.AccessDenied in get_memory_info#2078
Open
anxkhn wants to merge 1 commit into
Open
Conversation
On Linux, get_memory_info reads a process's PSS via memory_full_info, which psutil documents may require elevated privileges. In restricted environments (hardened containers with hidepid/restricted /proc, or an unreadable child subprocess) this raises psutil.AccessDenied, which is not a subclass of psutil.NoSuchProcess and so was not caught by the existing suppress around the child loop; the current-process read was unguarded entirely. The exception propagated out of the recurring system-info task, which has no error handling, silently stopping the autoscaler's CPU/memory snapshots. Suppress AccessDenied alongside NoSuchProcess when summing child memory, and fall back to RSS for the current process when PSS is denied. Signed-off-by: Anas Khan <83116240+anxkhn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_memory_info()insrc/crawlee/_utils/system.pycan crash withpsutil.AccessDeniedin restricted environments, which silently stops the autoscaler's CPU/memory snapshots._get_used_memoryreads a process's PSS viaprocess.memory_full_info()(/proc/<pid>/smaps). psutil documents thatmemory_full_info/ PSS may require elevated privileges, so in a hardened container (hidepid, restricted/proc, seccomp) or for an unreadable child subprocess it raisespsutil.AccessDenied.psutil.AccessDeniedis not a subclass ofpsutil.NoSuchProcess(MRO:AccessDenied -> Error -> Exception), so the existingwith suppress(psutil.NoSuchProcess)around the child loop did not catch it, and the current-process read at the top of the function was not guarded at all.SYSTEM_INFOtask (RecurringTask._wrapperhas no error handling), so the recurring task stops and the autoscaler quietly stops receiving snapshots.Fix, kept minimal:
A process can always read its own RSS, so the current-process fallback keeps a valid (slightly higher, RSS vs PSS) estimate instead of aborting the whole snapshot; an unreadable child is skipped just like a dead one.
Issues
get_memory_infofor cross-platform robustness (in the same spirit as the earlier PSS-on-Linux and macOS memory-estimation fixes to this file). Happy to open a tracking issue with the repro first if you'd prefer.get_memory_infodoes not raiseAccessDeniedin the first place (no file overlap; the two are complementary).Testing
tests/unit/_utils/test_system.py:test_get_memory_info_skips_children_with_access_denied: a child that raisesAccessDeniedis skipped rather than aborting the snapshot.test_get_memory_info_falls_back_to_rss_when_current_process_access_denied: PSS denial for the current process falls back to RSS.src/crawlee/_utils/system.py(keeping the new tests) makes both tests fail withpsutil.AccessDeniedpropagating out ofget_memory_info(); they pass with the fix.uv run pytest tests/unit/_utils/test_system.py-> 4 passed, 1 skipped (the skip is the Linux-only shared-memory test).uv run pytest tests/unit/events/ tests/unit/_autoscaling/-> green.uv run poe lint(ruff format + check) anduv run ty checkon the changed files both pass.Checklist