Fix OAuth token refresh for servers with root-based discovery (fixes #3) #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
discoverTokenEndpoint()function inoauth-utils.tsonly tries path-based OAuth discovery URLs:https://example.com/mcp/.well-known/oauth-authorization-serverhttps://example.com/mcp/.well-known/openid-configurationHowever, some servers like Notion host their OAuth metadata at the root:
https://mcp.notion.com/.well-known/oauth-authorization-serverThis causes token refresh to fail for these servers, even though initial login works (because the MCP SDK's
discoverAuthorizationServerMetadata()tries both path-based and root-based discovery).Solution
Add root-based fallback URLs to
discoverTokenEndpoint(), matching the behavior of the MCP SDK:Testing
discoverTokenEndpoint('https://mcp.notion.com/mcp')now correctly returnshttps://mcp.notion.com/tokenFixes #3