ci: gate release on atoms verification - #537
Merged
mykola-mokhnach merged 4 commits intoAug 13, 2026
Merged
Conversation
- publish.js.yml: type-check atoms/src and fail on build drift before running semantic-release, so a release can't ship stale atoms. - verify-atoms.yml: skip the simulator-based e2e job when the ref is master, since e2e tests must never run there.
The prior wording ("run it locally and commit the result") assumed a
PR context; this check runs on master during an automated release
where that guidance doesn't apply.
publish.js.yml already gates the release on atoms verification, so running verify-atoms.yml again on master push is redundant. Excluding master at the push trigger covers both jobs in one place instead of duplicating an if: condition on each.
Master is already covered by the release gate in publish.js.yml, and non-master branches are covered by pull_request. A separate push trigger (even branch-restricted) was redundant; this now matches functional-test.yml's pull_request + workflow_dispatch pattern.
Contributor
|
🎉 This PR is included in version 17.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also skip atoms e2e on master