test: download test apps from our repos and remove removal test apps #987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Dec 28, 2025
| <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value> | ||
| </resheader> | ||
| <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" /> | ||
| <data name="ApiDemos_debug" type="System.Resources.ResXFileRef, System.Windows.Forms"> |
Member
Author
There was a problem hiding this comment.
No references except for data names in this file and test/integration/helpers/Apps.cs
| public const string iosWebviewApp = "iosWebviewApp"; | ||
| public const string iosUICatalogApp = "iosUICatalogApp"; | ||
| public const string androidApiDemos = "androidApiDemos"; | ||
| public const string vodqaApp = "vodqaApp"; |
Member
Author
There was a problem hiding this comment.
Couldn't find references named vodqaApp in grep. It looks like this repo doesn't have test cases with this app
6 tasks
KazuCocoa
commented
Dec 28, 2025
| /// Amount of time in ms to wait for instruments before assuming it hung and failing the session | ||
| /// </summary> | ||
| public static readonly string LaunchTimeout = "launchTimeout"; | ||
| public static readonly string LaunchTimeout = "wdaLaunchTimeout"; |
Member
Author
There was a problem hiding this comment.
#989 will fix this. Then, will remove this change although this is needed to run local test with extended timeout
KazuCocoa
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the test infrastructure to download test applications from external repositories instead of embedding them as resources. The changes modernize the test app management by pointing to official Appium repositories and migrating test cases to use the iOS UICatalog app.
Key Changes:
- Replaced embedded test app resources with a dynamic download mechanism that fetches apps from GitHub URLs
- Updated iOS test cases (WebviewTest and LockDeviceTest) to use the iosUICatalogApp instead of iosWebviewApp
- Modified the LaunchTimeout capability key from "launchTimeout" to "wdaLaunchTimeout" to align with WebDriverAgent requirements
Reviewed changes
Copilot reviewed 7 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| test/integration/helpers/Apps.cs | Implements HTTP-based app downloading with caching, replacing embedded resources |
| test/integration/helpers/Caps.cs | Updates iOS simulator device and platform version configuration |
| test/integration/IOS/WebviewTest.cs | Refactored to work with iosUICatalogApp's web view functionality |
| test/integration/IOS/LockDeviceTest.cs | Changed to use iosUICatalogApp instead of iosWebviewApp |
| test/integration/Properties/Resources.resx | Removed embedded binary resources for test apps |
| test/integration/Properties/Resources.Designer.cs | Removed auto-generated resource accessor methods |
| test/integration/Appium.Net.Integration.Tests.csproj | Added System.Net.Http package dependency |
| src/Appium.Net/Appium/Enums/IOSMobileCapabilityType.cs | Updated capability key to wdaLaunchTimeout |
Files not reviewed (1)
- test/integration/Properties/Resources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dor-bl
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started working on appium/appium#7172 slowly.
iosTestAppis not removal yet. We want to replace it withiosUICatalogAppbased oneIntentExampleapk as no references