Apply --ulimit in container exec and machine run - #2267
Open
rishabhsai wants to merge 1 commit into
Open
rishabhsai wants to merge 1 commit into
rishabhsai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
container execandcontainer machine runembedFlags.Process, so both print--ulimit <limit>in their help and accept the flag without error, but neither ever readsprocessFlags.ulimits; the only reader isParser.processon the run/create path. Exec therefore keeps whatever rlimits the init process was started with and the value you passed is dropped with no warning, even though the guest already applies per-process rlimits on exec viaApp.setRLimits(rlimits: process.rlimits)in containerization'svmexec/ExecCommand.swift. #1129 added--ulimittoFlags.Processand wired it into run and create only, which is where the gap came from. This setsconfig.rlimitson exec when--ulimitis given, leaving the init process limits in place when it is not, and passesrlimits:into theProcessConfigurationthatmachine runbuilds.Fixes #2266
Testing
swift build --product containersucceeds and.build/debug/container exec --help | grep ulimitstill lists the flag, andmake swift-fmtleaves the diff unchanged. The newtestExecUlimitNofileinTestCLIExecCommandis compile-verified only: the integration suite needs an installed CLI and a running container system, which I could not run locally, so every test in that suite fails at fixture setup withbinaryNotFoundon my machine.