Use a custom entrypoint script for k8s container nodes - #2289
Open
katiewasnothere wants to merge 1 commit into
Open
katiewasnothere wants to merge 1 commit into
katiewasnothere wants to merge 1 commit into
Conversation
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
This PR eliminates the use of the default entrypoint script in the kindest/node image, which has logic specific to
kind's environment. For example, the kind entrypoint script has the function fix_machine_id() which is not necessary for apple/container since each cluster node runs in its own microVM, per the architectural design ofcontainer.From my investigation, the main risks of this change are in keeping the list of files that need to be updated on a restart up to date over time. While this is a meaningful concern, considering that most of kind's entrypoint script code is irrelevant and possibly even harmful for the apple/container environment today, this is a fair tradeoff.
This PR additionally fixes #2156 by handling certificate update and IP changes on a restart specifically for our environment. With the kind entrypoint script, many of the files that we depend on elsewhere in this repo such as
/root/.kube/configwere not properly updated.Testing