Remove k8s start command for now - #2290
Open
katiewasnothere wants to merge 1 commit into
Open
katiewasnothere wants to merge 1 commit into
katiewasnothere wants to merge 1 commit into
Conversation
Signed-off-by: Kathryn Baldauf <k_baldauf@apple.com>
Code Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Motivation and Context
The
container k8s startcommand was added to the k8s subcommand to support starting a previously stopped cluster node. Since cluster nodes show up in the higher levelcontainercommands such ascontainer lsandcontainer stop, it made sense to have the ability to additionally start control plane nodes for the k8s clusters withcontainer k8s start. However, since adding this subcommand, we've seen a number of issues around restarting (see 1) and we additionally have concerns about what the UX design should be for the k8s plugin moving forward.Since this is an experimental feature, this PR will remove
k8s startfor now while we work on improving the plugin overall. This will not only make the code easier to reason about from a developer point of view but additionally gives users less ways to potentially shoot themselves in the foot while we improve the feature.If a control plane node is stopped in a cluster, in lieu of
k8s start, to restart it, a user will need to delete the cluster withcontainer k8s deleteand re-create it withcontainer k8s create.We're open to feedback on this decision and use cases for
k8s start.Testing