Upgrade vminitd API to use grpc-swift-2.#578
Merged
jglogan merged 3 commits intoapple:mainfrom Mar 13, 2026
Merged
Conversation
- No real notable API changes. The largest change code-wise is in Vminitd. The connection loop is set up immediately in the new API by calling runConnections() on the client, and this blocks until either the task it's running on is cancelled or beginGracefulShutdown is called. Because of this, either we'd have to modify our API to have VirtualMachineAgent implementations call some run() method, or we just put runConnections in an internal task on Vminitd. This change uses the latter approach as it's simpler. - Updated dependencies to pick up latest protobuf and grpc-swift-2 fixes. - ClientBootstrap.withConnectedSocket(fd).wait() registers the vsock fd with epoll/kqueue immediately. vminitd sends its HTTP/2 SETTINGS frame right away upon accepting the connection, so those bytes can arrive on the fd — and be read by NIO — before the gRPC pipeline is installed. With a bare pipeline, NIO has nowhere to send the bytes and discards them. - Buffer until ClientConnectionHandler is in the pipeline so it can process the SETTINGS frame and fire .ready, then schedule delivery of the buffered data with assumeIsolatedUnsafeUnchecked().execute. Co-authored-by: Danny Canter <danny_canter@apple.com>
Member
|
Based off of #379 which we can close |
1 task
jglogan
added a commit
to jglogan/container
that referenced
this pull request
Mar 12, 2026
- Closes apple#1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
jglogan
added a commit
to jglogan/container
that referenced
this pull request
Mar 12, 2026
- Closes apple#1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
7 tasks
dcantah
approved these changes
Mar 13, 2026
Closed
7 tasks
jglogan
added a commit
to apple/container
that referenced
this pull request
Mar 16, 2026
- Closes #1308. - Applies dependency and code changes similar to apple/containerization#578. - Upgrades hawkeye to latest version. - Update StderrLogHandler not to create a (non-Sendable) Swift time formatter object for every log message.
crosbymichael
added a commit
to crosbymichael/containerization
that referenced
this pull request
Mar 17, 2026
This reverts commit 7ffe6d2.
crosbymichael
added a commit
to crosbymichael/containerization
that referenced
this pull request
Mar 17, 2026
This reverts commit 7ffe6d2.
jglogan
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StderrLogHandlerin the vminitd Application.swift that writes timestamps to the boot log with millisecond precision and format identical to that of the log files created using the--log-rootarg oncontainer.