SwiftQUIC: Expose Stateless Reset Token when CID is retired - #123
Open
agnosticdev wants to merge 7 commits into
Open
SwiftQUIC: Expose Stateless Reset Token when CID is retired#123agnosticdev wants to merge 7 commits into
agnosticdev wants to merge 7 commits into
Conversation
agnosticdev
requested review from
ekinnear,
kkuk24,
rpaulo and
tfpauly
as code owners
August 31, 2026 19:30
rpaulo
reviewed
Sep 2, 2026
|
|
||
| public var newInboundCIDEventCount = 0 | ||
| public var newOutboundCIDEventCount = 0 | ||
| public var retiredOutboundCIDEventCount = 0 |
Contributor
There was a problem hiding this comment.
I think the QUIC specific code should be in an extension.
Collaborator
Author
There was a problem hiding this comment.
We need to keep stored properties in the actual type.
rpaulo
reviewed
Sep 2, 2026
| case retiredInboundConnectionID(_ connectionID: QUICConnectionID) | ||
| case newOutboundConnectionID(_ connectionID: QUICConnectionID) | ||
| case retiredOutboundConnectionID(_ connectionID: QUICConnectionID) | ||
| case newOutboundConnectionID(_ connectionID: QUICConnectionID, statelessResetToken: QUICStatelessResetToken) |
Contributor
There was a problem hiding this comment.
Same comment about being in an extension
Collaborator
Author
There was a problem hiding this comment.
Moved this into a QUIC specific file: e2377c1
rpaulo
reviewed
Sep 2, 2026
| @available(Network 0.1.0, *) | ||
| final class SwiftNetworkQUICCIDTests: NetTestCase { | ||
|
|
||
| func testQUICRetiredOutboundConnectionIDIncludesStatelessResetToken() { |
Contributor
There was a problem hiding this comment.
I would argue that these should be in the QUICTest directory instead?
Collaborator
Author
There was a problem hiding this comment.
We could split out the QUIC related files here but I think we should move that to a new PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change exposes an associated stateless reset token when a connection id is retired.
This is used on the server for cleanup purposes and tracking.