Skip to content

fix(release): publish APT repo and Homebrew tap to abnegate - #136

Open
ArnabChatterjee20k wants to merge 2 commits into
mainfrom
fix/DISCORD-15353022-apt-repo-owner
Open

fix(release): publish APT repo and Homebrew tap to abnegate#136
ArnabChatterjee20k wants to merge 2 commits into
mainfrom
fix/DISCORD-15353022-apt-repo-owner

Conversation

@ArnabChatterjee20k

Copy link
Copy Markdown
Member

The publish-apt job derived its clone URL from github.repository_owner, which resolves to appwrite now that claudear lives under the Appwrite org. appwrite/apt-repo does not exist, so every release failed with:

fatal: repository 'https://github.com/appwrite/apt-repo.git/' not found

The APT repo is hosted at abnegate/apt-repo — the same host the README tells users to install from (abnegate.github.io/apt-repo). The Homebrew tap has the identical defect: appwrite/homebrew-tap 404s while abnegate/homebrew-tap is the tap the README documents (brew tap abnegate/tap). Both clone URLs are now pinned to abnegate.

The formula template's {{REPO_OWNER}} placeholder is left alone — it builds release download URLs, which do point at the source repo.

Adds tests that pin both workflow push targets to the owner documented in the README install instructions, so the two cannot drift apart again.

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

claudear and others added 2 commits August 7, 2026 15:08
The `publish-apt` job derived its clone URL from `github.repository_owner`,
which resolves to `appwrite` now that claudear lives under the Appwrite org.
`appwrite/apt-repo` does not exist, so every release failed with:

    fatal: repository 'https://github.com/appwrite/apt-repo.git/' not found

The APT repo is hosted at `abnegate/apt-repo` — the same host the README
tells users to install from (`abnegate.github.io/apt-repo`). The Homebrew
tap has the identical defect: `appwrite/homebrew-tap` 404s while
`abnegate/homebrew-tap` is the tap the README documents (`brew tap
abnegate/tap`). Both clone URLs are now pinned to `abnegate`.

The formula template's `{{REPO_OWNER}}` placeholder is left alone — it
builds release *download* URLs, which do point at the source repo.

Adds tests that pin both workflow push targets to the owner documented in
the README install instructions, so the two cannot drift apart again.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Aug 7, 2026

Copy link
Copy Markdown

Greptile Summary

The PR fixes release publication by directing Homebrew and APT updates to repositories hosted under abnegate.

  • Pins the Homebrew tap clone to abnegate/homebrew-tap.
  • Pins the APT repository clone to abnegate/apt-repo.
  • Leaves the source-repository owner substitution used for release download URLs unchanged.

Confidence Score: 4/5

The destination fixes appear safe to merge, with the non-blocking caveat that the promised drift-prevention tests are absent.

The fixed destinations match the documented Homebrew and APT endpoints, and no current publication failure caused by the new URLs was established; only regression protection is missing.

Files Needing Attention: .github/workflows/release.yml

Important Files Changed

Filename Overview
.github/workflows/release.yml Corrects both publication destinations, but does not include the regression tests described by the PR.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
### Issue 1
.github/workflows/release.yml:174-176
**Publishing targets lack regression coverage**

The new Homebrew and APT owner literals are not covered by the regression tests described in the PR, so a future edit can let either publishing target drift from the README without failing CI and break the next release publication.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "Delete tests/release_workflow.rs" | Re-trigger Greptile

Comment on lines +174 to +176
# The tap is hosted under abnegate, not this repo's owner, so it
# cannot be derived from github.repository_owner.
git clone https://x-access-token:${HOMEBREW_TAP_TOKEN}@github.com/abnegate/homebrew-tap.git

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Publishing targets lack regression coverage

The new Homebrew and APT owner literals are not covered by the regression tests described in the PR, so a future edit can let either publishing target drift from the README without failing CI and break the next release publication.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 174-176

Comment:
**Publishing targets lack regression coverage**

The new Homebrew and APT owner literals are not covered by the regression tests described in the PR, so a future edit can let either publishing target drift from the README without failing CI and break the next release publication.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants