Skip to content

feat: Node.js SDK update for version 23.1.0#146

Merged
ChiragAgg5k merged 2 commits intomainfrom
dev
Mar 31, 2026
Merged

feat: Node.js SDK update for version 23.1.0#146
ChiragAgg5k merged 2 commits intomainfrom
dev

Conversation

@ChiragAgg5k
Copy link
Copy Markdown
Member

This PR contains updates to the Node.js SDK for version 23.1.0.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

Warning

Rate limit exceeded

@ChiragAgg5k has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 19 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f8fa099-5efd-4cdb-964b-dde46a5b85c5

📥 Commits

Reviewing files that changed from the base of the PR and between 20b60d1 and b2ba29f.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (6)
  • .github/workflows/publish.yml
  • .gitignore
  • CHANGELOG.md
  • package.json
  • src/client.ts
  • test/services/account.test.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 31, 2026

Greptile Summary

This PR updates the Node.js SDK to version 23.1.0, adding a getHeaders() method to the Client class, committing the package-lock.json for deterministic installs, switching the publish workflow to npm ci, and improving MFA authenticator test fixtures with realistic TOTP values.

  • All version strings in client.ts, package.json, package-lock.json, and CHANGELOG.md are mutually consistent at 23.1.0.
  • Both concerns from the prior review are fully addressed: the lockfile root entry now has correct name, version, and license values; and the new getHeaders() method now includes a JSDoc block.
  • getHeaders() returns a shallow-spread copy of the internal headers map. The Headers return type annotation resolves to the locally defined type alias (a string-keyed string-valued record), not the global Fetch API Headers class — so there is no type mismatch.
  • Switching to npm ci in the publish workflow is the correct approach once the lockfile is committed.
  • No new bugs or security regressions were identified.

Confidence Score: 5/5

PR is safe to merge — all previous concerns addressed and no new issues found.

Both P1 findings from the prior review round (PLACEHOLDER values in package-lock.json and missing JSDoc on getHeaders) are resolved. No new P0 or P1 issues were identified. All remaining observations are P2 at most (e.g. no dedicated test for the new getHeaders method), which do not block merge.

No files require special attention.

Important Files Changed

Filename Overview
src/client.ts Added getHeaders() public method that returns a shallow copy of the headers map with appropriate JSDoc warning, and bumped version strings to 23.1.0. The local Headers type alias resolves correctly. No issues found.
package-lock.json New lockfile added with correct root-level name, version, and license values matching package.json — the PLACEHOLDER concern from the prior review has been resolved.
.github/workflows/publish.yml Switched from npm install to npm ci for reproducible installs; consistent with the newly added lockfile.
test/services/account.test.js Replaced stub '1' values with realistic TOTP otpauth:// URI strings in mock fixture for MFA authenticator tests. No logic changes.
package.json Version bumped from 23.0.0 to 23.1.0, consistent with CHANGELOG.md, package-lock.json, and version strings in client.ts.
.gitignore New file adding standard ignores for node_modules/, dist/, and .DS_Store.
CHANGELOG.md Version 23.1.0 entry added with accurate descriptions of all changes included in this PR.

Reviews (2): Last reviewed commit: "chore: update Node.js SDK to 23.1.0" | Re-trigger Greptile

@ChiragAgg5k ChiragAgg5k merged commit bd96eef into main Mar 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants